Re: [PATCH] net: stmmac: enable MAC after MTL configuring
From: Simon Horman
Date: Thu Oct 17 2024 - 06:19:09 EST
On Mon, Oct 14, 2024 at 01:44:03PM +0800, 2694439648@xxxxxx wrote:
> From: "hailong.fan" <hailong.fan@xxxxxxxxxxxx>
>
> DMA maybe block while ETH is opening,
> Adjust the enable sequence, put the MAC enable last
>
> Signed-off-by: hailong.fan <hailong.fan@xxxxxxxxxxxx>
Hi,
I think that some more explanation of this is required.
Including if a problem has been observed, and if so under what
conditions. Or, if not, some background information on why
this adjustment is correct.
I also think some explanation is required of the relationship
between the changes this patch makes to setup, and the
changes it makes to start and stop.
...