Re: [PATCH v2] misc: misc_minor_alloc to use ida for all dynamic/misc dynamic minors

[Vimal Agrawal]

Hi Jeff,

Thanks. I will be adding MODULE_DESCRIPTION in the next version of the
patch. Will be splitting kunit changes from this patch in two patch
series.

Vimal

On Wed, Oct 16, 2024 at 3:48 AM Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote:
>
> On 10/15/24 00:02, Vimal Agrawal wrote:
> ...
> > +static struct kunit_suite test_suite = {
> > +     .name = "misc_minor_test",
> > +     .test_cases = test_cases,
> > +};
> > +kunit_test_suite(test_suite);
> > +
> > +MODULE_LICENSE("GPL");
>
> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
> description is missing"), a module without a MODULE_DESCRIPTION() will
> result in a warning when built with make W=1. Recently, multiple
> developers have been eradicating these warnings treewide, and very few
> (if any) are left, so please don't introduce a new one :)
>
> Please add the missing MODULE_DESCRIPTION()
>
> /jeff