Re: [PATCH v3 0/8] CSV/JSON metric thresholds, fix printf modifiers

From: Ian Rogers
Date: Thu Oct 17 2024 - 12:45:51 EST


On Thu, Oct 17, 2024 at 9:39 AM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
> On Wed, 16 Oct 2024 10:53:42 -0700, Ian Rogers wrote:
>
> > Metric thresholds are being computed for CSV and JSON output but not
> > displayed. Rename the color that encodes the threshold as enum values
> > and use to generate string constants in a CSV column or json
> > dictionary value.
> >
> > Add printf attribute to functions in color.h that could support
> > it. Fix bad printf format strings that this detected.
> >
> > [...]
>
> Applied to perf-tools-next, thanks!

Sorry for the trouble, could we switch to the v4 series due to issues
on hypervisors with not counted events in CSV output missing a column:
https://lore.kernel.org/lkml/20241016215139.212939-1-irogers@xxxxxxxxxx/
The patch set drops the CSV output metric threshold support.

Thanks,
Ian