Re: 回复: [PATCH v1] riscv: dts: starfive: disable unused csi/camss nodes
From: Conor Dooley
Date: Thu Oct 17 2024 - 13:52:16 EST
On Thu, Oct 17, 2024 at 05:49:56AM +0000, Changhuang Liang wrote:
> Hi, Conor,
>
> > Hi, Conor
> >
> > Thanks for your patch.
> >
> > > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > >
> > > Aurelien reported probe failures due to the csi node being enabled
> > > without having a camera attached to it. A camera was in the initial
> > > submissions, but was removed from the dts, as it had not actually been
> > > present on the board, but was from an addon board used by the developer
> > of the relevant drivers.
> > > The non-camera pipeline nodes were not disabled when this happened and
> > > the probe failures are problematic for Debian. Disable them.
> > >
> > > CC: stable@xxxxxxxxxxxxxxx
> > > Fixes: 28ecaaa5af192 ("riscv: dts: starfive: jh7110: Add camera
> > > subsystem
> > > nodes")
> >
> > Here you write it in 13 characters, should be "Fixes: 28ecaaa5af19 ..."
> >
>
> After fixing this:
> Reviewed-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
Ye, I know it was 13 not 12. I don't think that's a problem though.
Attachment:
signature.asc
Description: PGP signature