Re: [PATCH 2/4] kunit: qemu_configs: add LoongArch config

[Shuah Khan]

On 10/17/24 14:31, Thomas Weißschuh wrote:
> Hi Shuah,
>
> Oct 17, 2024 22:27:29 Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>:
>
> > On 10/14/24 05:36, Thomas Weißschuh wrote:
> > > Add a basic config to run kunit tests on LoongArch.
> > > This requires QEMU 9.1.0 or later for the necessary direct kernel boot
> > > support.
> > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> > > ---
> > >    tools/testing/kunit/qemu_configs/loongarch.py | 16 ++++++++++++++++
> > >    1 file changed, 16 insertions(+)
> > > diff --git a/tools/testing/kunit/qemu_configs/loongarch.py b/tools/testing/kunit/qemu_configs/loongarch.py
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..e7bb7c07819677dfdefac012821a732555813cae
> > > --- /dev/null
> > > +++ b/tools/testing/kunit/qemu_configs/loongarch.py
> >
> > Missing SPDX-License-Identifier.
>
> Tue others configs don't have one either.
>
> > > @@ -0,0 +1,16 @@
> > > +from ..qemu_config import QemuArchParams
> > > +
> > > +QEMU_ARCH = QemuArchParams(linux_arch='loongarch',
> > > +              kconfig='''
> > > +CONFIG_EFI_STUB=n
> > > +CONFIG_PCI_HOST_GENERIC=y
> > > +CONFIG_SERIAL_8250=y
> > > +CONFIG_SERIAL_8250_CONSOLE=y
> > > +CONFIG_SERIAL_OF_PLATFORM=y
> > > +''',
> > > +              qemu_arch='loongarch64',
> > > +              kernel_path='arch/loongarch/boot/vmlinux.elf',
> > > +              kernel_command_line='console=ttyS0',
> > > +              extra_qemu_params=[
> > > +                      '-machine', 'virt',
> > > +                      '-cpu', 'max',])
> >
> > Please send v2 with all the reviewed by tags. If there
> > is a resend 3.4 and 4/4 in this series, send them.
>
> I'll do that. But it will take some weeks, as I just went on vacation.

Sounds good. Enjoy your vacation.

thanks,
-- Shuah