Re: [PATCH] genirq/devres: Simplify API devm_free_irq() implementation

[Zijun Hu]

On 2024/10/18 04:33, Thomas Gleixner wrote:
> On Thu, Oct 17 2024 at 23:16, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
>>
>> Simplify devm_free_irq() implementation by dedicated API devres_release()
>> which have below advantages than current devres_destroy() + free_irq().
>>
>> It is simpler if devm_free_irq() is undoing what any devm_request_irq()
>> variant did, otherwise, it can avoid wrong and undesired free_irq().
> 
> This is confusing at best. What's the wrong an undesired free_irq()?
> 

thanks for code review.

for current devm_free_irq(..., irq_A, ...):
it is undesired if irq_A is requested by request_irq().
it is wrong and dangerous if irq_A was never requested.

sorry to have confused commit message.
any suggestion to correct it ? (^^)

> Thanks,
> 
>         tglx