Re: [PATCH v5 3/3] s390: Remove remaining _PAGE_* macros

[Alexander Gordeev]

On Mon, Oct 14, 2024 at 04:13:40PM +0100, Vincenzo Frascino wrote:

Hi Vincenzo,

> The introduction of vdso/page.h made redundant the definition of
> _PAGE_SHIFT, _PAGE_SIZE, _PAGE_MASK.
> 
> Refactor the code to remove the macros.
> 
> Cc: Heiko Carstens <hca@xxxxxxxxxxxxx>
> Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx>
> Cc: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Andy Lutomirski <luto@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Jason A. Donenfeld <Jason@xxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410112106.mvc2U2p0-lkp@xxxxxxxxx/

Is my understanding correct that with patch 3/3 you fix an issue
introduced with patch 2/3?

> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
> ---
>  arch/s390/include/asm/page.h    | 3 ---
>  arch/s390/include/asm/pgtable.h | 2 +-
>  arch/s390/mm/fault.c            | 2 +-
>  arch/s390/mm/gmap.c             | 6 +++---
>  arch/s390/mm/pgalloc.c          | 4 ++--
>  5 files changed, 7 insertions(+), 10 deletions(-)

Thanks!