Re: [PATCH] ARM: dts: aspeed: Add device tree for Ampere's Mt. Jefferson BMC

[Chanh Nguyen]

On 18/10/2024 11:34, Andrew Jeffery wrote:
> Hi Chanh,
>
> On Mon, 2024-10-14 at 10:50 +0000, Chanh Nguyen wrote:
> > +&mac3 {
> > +	status = "okay";
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pinctrl_rmii4_default>;
> > +	clock-names = "MACCLK", "RCLK";
>
> Should this be overriding `clocks` also? There's only one clock
> specified in the dtsi.

Thank Andrew,
I think it is redundant config. I don't need to override the `clock` and 
`clock-names` here. The mac3 will use the clock specified in the dtsi.
I'll remove `clock-names` in the patch v2

Summary, I need to update as the below list.
1. Add Mt. Jefferson board compatible binding as Krzysztof pointed.
2. Remove the PSU node with "pmbus" compatible.
3. Remove `clock-names' property in mac3 node

Regards,
Chanh

> Andrew
>
> > +	use-ncsi;
> > +};