Re: [PATCH] cdrom: Avoid barrier_nospec() in cdrom_ioctl_media_changed()

From: Phillip Potter
Date: Fri Oct 18 2024 - 06:32:00 EST


On Thu, Oct 17, 2024 at 07:47:31PM -0600, Jens Axboe wrote:
>
> On Thu, 17 Oct 2024 15:09:02 -0700, Josh Poimboeuf wrote:
> > The barrier_nospec() after the array bounds check is overkill and
> > painfully slow for arches which implement it.
> >
> > Furthermore, most arches don't implement it, so they remain exposed to
> > Spectre v1 (which can affect pretty much any CPU with branch
> > prediction).
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] cdrom: Avoid barrier_nospec() in cdrom_ioctl_media_changed()
> commit: b0bf1afde7c34698cf61422fa8ee60e690dc25c3
>
> Best regards,
> --
> Jens Axboe
>
>
>

Sorry for lack of reply, this conversation took place in the early hours
for my timezone and thus I was unconscious :-)

Change sounds good to me for the aforementioned reasons.

Regards,
Phil