Re: [PATCH] resource,kexec: walk_system_ram_res_rev must retain resource flags
From: Andy Shevchenko
Date: Fri Oct 18 2024 - 08:22:50 EST
On Fri, Oct 18, 2024 at 10:18:42AM +0800, Baoquan He wrote:
> HI Gregory,
>
> On 10/17/24 at 03:03pm, Gregory Price wrote:
> > walk_system_ram_res_rev() erroneously discards resource flags when
> > passing the information to the callback.
> >
> > This causes systems with IORESOURCE_SYSRAM_DRIVER_MANAGED memory to
> > have these resources selected during kexec to store kexec buffers
> > if that memory happens to be at placed above normal system ram.
>
> Sorry about that. I haven't checked IORESOURCE_SYSRAM_DRIVER_MANAGED
> memory carefully, wondering if res could be set as
> 'IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY' plus
> IORESOURCE_SYSRAM_DRIVER_MANAGED in iomem_resource tree.
>
> Anyway, the change in this patch is certainly better. Thanks.
Can we get more test cases in the respective module, please?
--
With Best Regards,
Andy Shevchenko