Re: [PATCH 3/4] dt-bindings: iio: light: veml6075: document rset-kohms

From: Rob Herring
Date: Fri Oct 18 2024 - 09:30:02 EST


On Thu, Oct 17, 2024 at 11:39:27PM +0200, Javier Carrasco wrote:
> The veml6070 provides a configurable integration time by means of an
> extertnal resistor (Rset in the datasheet) with values between 75 and
> 1200 kohms.
>
> Document rset-kohms to select the integration time.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
> ---
> .../devicetree/bindings/iio/light/vishay,veml6075.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> index 96c1317541fa..3d3ffeaa22df 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> @@ -29,6 +29,22 @@ required:
> - reg
> - vdd-supply
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + enum:
> + - vishay,veml6070
> + then:
> + properties:
> + rset-kohms:

Use the documented '-ohms' suffix.

Properties should be defined at the top-level and then restricted here.

> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Value in kilo Ohms of the Rset resistor used to select
> + the integration time.
> + minimum: 75
> + maximum: 1200
> +
> additionalProperties: false
>
> examples:
>
> --
> 2.43.0
>