Re: [PATCH net-next] net/sched: act_api: unexport tcf_action_dump_1()

From: Simon Horman
Date: Fri Oct 18 2024 - 10:23:34 EST


On Thu, Oct 17, 2024 at 07:19:34PM +0300, Vladimir Oltean wrote:
> This isn't used outside act_api.c, but is called by tcf_dump_walker()
> prior to its definition. So move it upwards and make it static.
>
> Simultaneously, reorder the variable declarations so that they follow
> the networking "reverse Christmas tree" coding style.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>

Christmas has come early this year :)

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>