Re: [PATCH v2 0/3] Make "Setup struct perf_event_attr" a shell test
From: Namhyung Kim
Date: Fri Oct 18 2024 - 11:20:52 EST
On Mon, 14 Oct 2024 17:01:55 -0700, Ian Rogers wrote:
> The path detection for "Setup struct perf_event_attr" test is brittle
> and leads to the test frequently not running. Running shell tests is
> reasonably robust, so make the test a shell test. Move the test files
> to reflect this.
>
> Before, if you build perf like `make -C tools/perf O=/tmp/perf` then
> run the built perf test for the "Setup struct perf_event_attr" it
> skips (causing the tests to bitrot, fixes to be sent, etc.):
> ```
> $ sudo /tmp/perf/perf test -vv perf_event_attr
> capget syscall failed (No such file or directory - 2) fall back on root check
> 17: Setup struct perf_event_attr:
> 17: Setup struct perf_event_attr:
> --- start ---
> test child forked, pid 806601
> Using CPUID GenuineIntel-6-8D-1
> ---- end(-2) ----
> 17: Setup struct perf_event_attr : Skip
> ```
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung