Re: [PATCH net-next] net: phy: aquantia: Add mdix config and reporting

[Andrew Lunn]

> As auto-negotiation is required for 1000BASE-T (and higher speed
> twisted pair modes) the question of whether Auto MDI/MDI-X detection
> occurs when auto-negotiation is turned off is only really relevant for
> 10BASE-T and 100BASE-T being forced.

Yes.

> When I was wondering if mdix_ctrl being set to ETH_TP_MDI_AUTO should
> be rejected if auto-negotiation is disabled I meant for this specific
> PHY driver as it definitely does not appear to perform the Auto
> MDI/MDI-X resolution so if the wiring/cabling between and/or config on
> the link partner does not match the default (MDI I think for the AQR)
> then the link will not establish.

Well, as you say, 1000Base-T needs autoneg, so there is no need to
reject ETH_TP_MDI_AUTO for that link mode and above.

It seems like for lower speeds, ETH_TP_MDI_AUTO could work without
autoneg. So to me, this validation is not a core feature, but per PHY.
Please feel free to implement it for this PHY.

    Andrew

---
pw-bot: cr