Re: [PATCH v2 00/10] x86/mce: Clean up some x86/mce code

From: Sohil Mehta
Date: Fri Oct 18 2024 - 16:40:33 EST


On 10/16/2024 5:30 AM, Qiuxu Zhuo wrote:

> Qiuxu Zhuo (10):
> x86/mce/dev-mcelog: Use xchg() to get and clear the flags
> x86/mce/intel: Use MCG_BANKCNT_MASK instead of 0xff
> x86/mce: Make several functions return bool
> x86/mce/threshold: Remove the redundant this_cpu_dec_return()
> x86/mce/genpool: Make mce_gen_pool_create() return explicit error codes
> x86/mce: Convert multiple if () statements into a switch() statement
> x86/mce: Remove the unnecessary {}
> x86/mce: Remove the redundant zeroing assignments
> x86/mce/amd: Remove unnecessary NULL pointer initializations
> x86/mce: Fix typos in comments
>

Apart from the minor nits and commit message changes, the patches look
fine to me.

With those addressed,
Reviewed-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>