Re: [PATCH v2] Input: zinitix - Don't fail if linux,keycodes prop is absent

From: Dmitry Torokhov
Date: Fri Oct 18 2024 - 20:13:45 EST


On Fri, Oct 04, 2024 at 09:17:30PM +0500, Nikita Travkin wrote:
> When initially adding the touchkey support, a mistake was made in the
> property parsing code. The possible negative errno from
> device_property_count_u32() was never checked, which was an oversight
> left from converting to it from the of_property as part of the review
> fixes.
>
> Re-add the correct handling of the absent property, in which case zero
> touchkeys should be assumed, which would disable the feature.
>
> Reported-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx>
> Tested-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx>
> Fixes: 075d9b22c8fe ("Input: zinitix - add touchkey support")
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Nikita Travkin <nikita@xxxxxxx>

Applied, thank you.

--
Dmitry