[PATCH v2 3/3] perf disasm: Fix not cleaning up disasm_line in symbol__disassemble_raw()
From: Li Huafei
Date: Sat Oct 19 2024 - 03:41:22 EST
In symbol__disassemble_raw(), the created disasm_line should be
discarded before returning an error. When creating disasm_line fails,
break the loop and then release the created lines.
Fixes: 0b971e6bf1c3 ("perf annotate: Add support to capture and parse raw instruction in powerpc using dso__data_read_offset utility")
Signed-off-by: Li Huafei <lihuafei1@xxxxxxxxxx>
---
Changes in v2:
- Break directly in the loop when it fails, then free disasm_line.
---
tools/perf/util/disasm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c
index 8a24e31a1534..250cc5ef4762 100644
--- a/tools/perf/util/disasm.c
+++ b/tools/perf/util/disasm.c
@@ -1770,7 +1770,7 @@ static int symbol__disassemble_raw(char *filename, struct symbol *sym,
sprintf(args->line, "%x", line[i]);
dl = disasm_line__new(args);
if (dl == NULL)
- goto err;
+ break;
annotation_line__add(&dl->al, ¬es->src->source);
offset += 4;
--
2.25.1