Re: [PATCH net-next v3] net: atlantic: support reading SFP module info

[Simon Horman]

On Fri, Oct 18, 2024 at 07:17:18PM +0200, Lorenz Brun wrote:
> Add support for reading SFP module info and digital diagnostic
> monitoring data if supported by the module. The only Aquantia
> controller without an integrated PHY is the AQC100 which belongs to
> the B0 revision, that's why it's only implemented there.
> 
> The register information was extracted from a diagnostic tool made
> publicly available by Dell, but all code was written from scratch by me.
> 
> This has been tested to work with a variety of both optical and direct
> attach modules I had lying around and seems to work fine with all of
> them, including the diagnostics if supported by an optical module.
> All tests have been done with an AQC100 on an TL-NT521F card on firmware
> version 3.1.121 (current at the time of this patch).
> 
> Signed-off-by: Lorenz Brun <lorenz@xxxxxxxx>
> ---
> No content changes, thus resent as v3 with just the target tree changed.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>