Re: [PATCH v1 1/1] iio: magnetometer; bmc150_magn: Drop most likely fake ACPI IDs

From: Hans de Goede
Date: Sat Oct 19 2024 - 06:03:36 EST


Hi,

On 18-Oct-24 4:58 PM, Andy Shevchenko wrote:
> The commits in question do not proove that ACPI IDs exist.
> Quite likely it was a cargo cult addition while doing that
> for DT-based enumeration. Drop most likely fake ACPI IDs.
>
> The to be removed IDs has been checked against the following resources:
> 1) DuckDuckGo
> 2) Google
> 3) MS catalog: https://www.catalog.update.microsoft.com/Search.aspx
> This gives no useful results in regard to DSDT, moreover, the official
> vendor IDs in the registry for Bosh are BSG and BOSC.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>



These HIDs are also not used in my acpidump collection (mostly
BYT / CHT models):

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans




> ---
> drivers/iio/magnetometer/bmc150_magn_i2c.c | 9 ---------
> drivers/iio/magnetometer/bmc150_magn_spi.c | 9 ---------
> 2 files changed, 18 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/bmc150_magn_i2c.c b/drivers/iio/magnetometer/bmc150_magn_i2c.c
> index a28d46d59875..17e10a462ac8 100644
> --- a/drivers/iio/magnetometer/bmc150_magn_i2c.c
> +++ b/drivers/iio/magnetometer/bmc150_magn_i2c.c
> @@ -38,14 +38,6 @@ static void bmc150_magn_i2c_remove(struct i2c_client *client)
> bmc150_magn_remove(&client->dev);
> }
>
> -static const struct acpi_device_id bmc150_magn_acpi_match[] = {
> - {"BMC150B", 0},
> - {"BMC156B", 0},
> - {"BMM150B", 0},
> - {},
> -};
> -MODULE_DEVICE_TABLE(acpi, bmc150_magn_acpi_match);
> -
> static const struct i2c_device_id bmc150_magn_i2c_id[] = {
> { "bmc150_magn" },
> { "bmc156_magn" },
> @@ -67,7 +59,6 @@ static struct i2c_driver bmc150_magn_driver = {
> .driver = {
> .name = "bmc150_magn_i2c",
> .of_match_table = bmc150_magn_of_match,
> - .acpi_match_table = bmc150_magn_acpi_match,
> .pm = &bmc150_magn_pm_ops,
> },
> .probe = bmc150_magn_i2c_probe,
> diff --git a/drivers/iio/magnetometer/bmc150_magn_spi.c b/drivers/iio/magnetometer/bmc150_magn_spi.c
> index abc75a05c46a..c850de1bc79b 100644
> --- a/drivers/iio/magnetometer/bmc150_magn_spi.c
> +++ b/drivers/iio/magnetometer/bmc150_magn_spi.c
> @@ -41,20 +41,11 @@ static const struct spi_device_id bmc150_magn_spi_id[] = {
> };
> MODULE_DEVICE_TABLE(spi, bmc150_magn_spi_id);
>
> -static const struct acpi_device_id bmc150_magn_acpi_match[] = {
> - {"BMC150B", 0},
> - {"BMC156B", 0},
> - {"BMM150B", 0},
> - {},
> -};
> -MODULE_DEVICE_TABLE(acpi, bmc150_magn_acpi_match);
> -
> static struct spi_driver bmc150_magn_spi_driver = {
> .probe = bmc150_magn_spi_probe,
> .remove = bmc150_magn_spi_remove,
> .id_table = bmc150_magn_spi_id,
> .driver = {
> - .acpi_match_table = bmc150_magn_acpi_match,
> .name = "bmc150_magn_spi",
> },
> };