Re: [PATCH net-next 1/8] lib: packing: create __pack() and __unpack() variants without error checking
From: Vladimir Oltean
Date: Sat Oct 19 2024 - 08:46:19 EST
On Fri, Oct 11, 2024 at 11:48:29AM -0700, Jacob Keller wrote:
> From: Vladimir Oltean <vladimir.oltean@xxxxxxx>
>
> A future variant of the API, which works on arrays of packed_field
> structures, will make most of these checks redundant. The idea will be
> that we want to perform sanity checks only once at boot time, not once
> for every function call. So we need faster variants of pack() and
The "idea" changed between writing the commit message and the final
implementation. Can you restate "sanity checks only once at boot time"
and make it "sanity checks at compile time"?
> unpack(), which assume that the input was pre-sanitized.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> ---