Re: [netfilter-core] [PATCH v2] netfilter: xtables: fix typo causing some targets to not load on IPv6

[Pablo Neira Ayuso]

On Sat, Oct 19, 2024 at 08:10:29PM +0200, Pablo Neira Ayuso wrote:
> Hi,
> 
> Thanks for your patch.
> 
> On Sat, Oct 19, 2024 at 08:05:07AM +0300, Ilya Katsnelson wrote:
> > These were added with the wrong family in 4cdc55e, which seems
> > to just have been a typo, but now ip6tables rules with --set-mark
> > don't work anymore, which is pretty bad.
> 
> There is at least one more issue, TRACE is missing this chunk:
> 
> diff --git a/net/netfilter/xt_TRACE.c b/net/netfilter/xt_TRACE.c
> index f3fa4f11348c..a642ff09fc8e 100644
> --- a/net/netfilter/xt_TRACE.c
> +++ b/net/netfilter/xt_TRACE.c
> @@ -49,6 +49,7 @@ static struct xt_target trace_tg_reg[] __read_mostly = {
>                 .target         = trace_tg,
>                 .checkentry     = trace_tg_check,
>                 .destroy        = trace_tg_destroy,
> +               .me             = THIS_MODULE,
>         },
>  #endif
>  };

I will post a v2 including this chunk.

Thanks.