Re: [PATCH v1] usb: storage: use US_BULK_FLAG_OUT instead of constant values

From: Greg KH
Date: Sun Oct 20 2024 - 02:17:30 EST

Next message: Greg KH: "Re: [PATCH] drivers/net/usb: Lenovo Mini Dock, add support for new USB device ID 0x17EF:0x3098 for the r8152 driver"
Previous message: Edward Adam Davis: "[PATCH] xfs: If unable to pick perag an error needs to be returned"
In reply to: Dingyan Li: "[PATCH v1] usb: storage: use US_BULK_FLAG_OUT instead of constant values"
Next in thread: Dingyan Li: "[PATCH v2] usb: storage: use US_BULK_FLAG_OUT instead of constant values"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, Oct 20, 2024 at 12:08:22AM +0800, Dingyan Li wrote:
> Macros with good names offer better readability. Besides, fix an error
> in the comments. In the flags, direction is in bit 7 instead of bit 0.

That means this should be at least 2 different patches please.
Remember, each change only does one logical thing.

thanks,

greg k-h

Next message: Greg KH: "Re: [PATCH] drivers/net/usb: Lenovo Mini Dock, add support for new USB device ID 0x17EF:0x3098 for the r8152 driver"
Previous message: Edward Adam Davis: "[PATCH] xfs: If unable to pick perag an error needs to be returned"
In reply to: Dingyan Li: "[PATCH v1] usb: storage: use US_BULK_FLAG_OUT instead of constant values"
Next in thread: Dingyan Li: "[PATCH v2] usb: storage: use US_BULK_FLAG_OUT instead of constant values"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]