Re: [PATCH v2 4/6] iio: imu: bmi270: Add support for BMI260

From: Jonathan Cameron
Date: Sun Oct 20 2024 - 07:00:22 EST



> >> #define BMI270_CHIP_ID_REG 0x00
> >> +#define BMI160_CHIP_ID_VAL 0xD1
> >
> > This one looks like a cut and paste error.
>
> No, this was intentional -- I added the BMI160 chip ID here so it could
> be checked later to avoid conflicting with the existing bmi160 driver. I
> could add newlines before and after this group of _ID_VAL #defines if it
> makes it clearer.

Got it. Just add a comment that it's to exclude known bad firmwares and
that is fine to keep.