Re: [PATCH 2/3] printf: Add print format (%pra) for struct range
From: Andy Shevchenko
Date: Mon Oct 21 2024 - 02:58:11 EST
On Fri, Oct 18, 2024 at 01:05:22PM -0700, Dan Williams wrote:
> Ira Weiny wrote:
...
> > + %pra [range 0x0000000060000000]
> > +
> > +For printing struct range. struct range holds an arbitrary range of u64
> > +values. If start is equal to end only print the start value.
>
> I was going to say "why this special case that does not exist for the
> %pr case?", but then checked the code and found it *does* do this for %pr.
> So if you're going to document this special case for %pra might as well
> update the documentation for %pr too.
>
> Alternatively, drop the new %pra documentation for this corner case as
> accommodating the U64_MAX size range case is arguably a mistake in the
> caller.
You probably meant "...(U64_MAX + 1) size..." as we end up with the same value.
But yeah, I also noticed the same.
--
With Best Regards,
Andy Shevchenko