RE: [RFC PATCH] tty: atmel_serial: Use devm_platform_ioremap_resource()

From: Mihai.Sain
Date: Mon Oct 21 2024 - 03:16:41 EST


> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Monday, October 21, 2024 10:00 AM
> To: Mihai Sain - M19926 <Mihai.Sain@xxxxxxxxxxxxx>
> Cc: richard.genoud@xxxxxxxxxxx; jirislaby@xxxxxxxxxx; Nicolas Ferre - M43238
> <Nicolas.Ferre@xxxxxxxxxxxxx>; alexandre.belloni@xxxxxxxxxxx;
> claudiu.beznea@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> serial@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [RFC PATCH] tty: atmel_serial: Use
> devm_platform_ioremap_resource()
>
> On Mon, Oct 21, 2024 at 09:43:21AM +0300, Mihai Sain wrote:
> > Simplify the request port function by using a single call to
> > devm_platform_ioremap_resource().
> >
> > This will also enhance the printing from /proc/iomem:
> >
> > cat /proc/iomem | grep flexcom ; cat /proc/iomem | grep serial
> >
> > f0004000-f00041ff : f0004000.flexcom flexcom@f0004000
> > f8020000-f80201ff : f8020000.flexcom flexcom@f8020000
> > f0004200-f00043ff : f0004200.serial serial@200 f8020200-f80203ff :
> > f8020200.serial serial@200 fffff200-fffff3ff : fffff200.serial
> > serial@fffff200
> >
> > Signed-off-by: Mihai Sain <mihai.sain@xxxxxxxxxxxxx>
> > ---
> > drivers/tty/serial/atmel_serial.c | 12 +++---------
> > 1 file changed, 3 insertions(+), 9 deletions(-)
>
> Why is this a rfc? What needs to be done before you want it merged?

I used the rfc tag in order to get the feedback from you and all stakeholders.
If the modifications are OK for you I will send a new patch without rfc tag.

Thanks,
Mihai

>
> thanks,
>
> greg k-h