RE: [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Fujitsu MONAKA

[Yoshihiro Furudera (Fujitsu)]

Hi, Andy Shevchenko
Thanks for you review/comments.

> On Fri, Oct 18, 2024 at 01:58:26AM +0000, Yoshihiro Furudera wrote:
> > This patch enables DWAPB I2C controller support on Fujitsu MONAKA.
> 
> s/This patch enables/Enable/

Understood.

> 
> Also please give more details:
> 1) is this ID already present in the wild
>    (in the products that one may just go and buy)?
> if so, mention the example of the product.

Not available at this time.
It is planned to be implemented in the MONAKA server
scheduled for shipment in 2027.

> 
> 2) provide an excerpt from DSDT for the Device object that uses this _HID.

The DSDT information obtained when verified using
an in-house simulator is presented below.

DefinitionBlock ("", "SSDT", 2, "FUJ   ", "NGDC    ", 0x00000001)
{
    Scope (\_SB)
    {
        Device (SMB0)
        {
            Name (_HID, "FUJI200B")  // _HID: Hardware ID
            Name (_UID, Zero)  // _UID: Unique ID
            Method (_STA, 0, NotSerialized)  // _STA: Status
            {
                Return (0x0F)
            }
 
            Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
            {
                Memory32Fixed (ReadWrite,
                    0x2A4B0000,         // Address Base
                    0x00010000,         // Address Length
                    )
                Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
                {
                    0x00000159,
                }
            })
            Device (SSIF)
            {
                Name (_HID, EisaId ("IPI0001"))  // _HID: Hardware ID
                Name (_UID, Zero)  // _UID: Unique ID
                Name (_STR, Unicode ("IPMI_SSIF"))  // _STR: Description String
                Method (_IFT, 0, NotSerialized)  // _IFT: IPMI Interface Type
                {
                    Return (0x04)
                }
 
                Method (_ADR, 0, NotSerialized)  // _ADR: Address
                {
                    Return (0x20)
                }
 
                Method (_SRV, 0, NotSerialized)  // _SRV: IPMI Spec Revision
                {
                    Return (0x0200)
                }
            }
        }
    }
}

> 
> Otherwise the vendor ID is legit [1] and code wise patch is okay.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> [1]: https://uefi.org/ACPI_ID_List?acpi_search=fuji
> 
> --
> With Best Regards,
> Andy Shevchenko
>

Best Regards,
Yoshihiro Furudera