Re: [PATCH] iwlwifi: work around -Wenum-compare-conditional warning

[Kalle Valo]

"Arnd Bergmann" <arnd@xxxxxxxx> writes:

> On Fri, Oct 18, 2024, at 16:06, Kalle Valo wrote:
>> Arnd Bergmann <arnd@xxxxxxxxxx> writes:
>>
>>> From: Arnd Bergmann <arnd@xxxxxxxx>
>>>
>>> This is one of only three -Wenum-compare-conditional warnings we get
>>> in randconfig builds:
>>>
>>> drivers/net/wireless/intel/iwlwifi/mvm/sta.c:4331:17: error: conditional expression between different enumeration types ('enum iwl_fw_sta_type' and 'enum iwl_sta_type') [-Werror,-Wenum-compare-conditional]
>>>  4331 |         u32 type = mld ? STATION_TYPE_PEER : IWL_STA_LINK;
>>>       |                        ^ ~~~~~~~~~~~~~~~~~   ~~~~~~~~~~~~
>>>
>>> This is a false positive since the code works as intended, but the
>>> warning is otherwise sensible, so slightly rewrite it in order to
>>> not trigger the warning.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>>
>> Is this and the other rtw89 patch for current release or -next?
>
> Up to you, the warning has existed for a long time at W=1
> level, so the patch applies to current and stable kernels
> as well, but it's not a regression or particularly important.

Ok, I guess -next is more approriate then.

> It would be nice to turn on the warning by default in 6.13
> once the three patches I sent get applied.

It's not certain if driver specific trees make it to v6.13 so should the
patches applied directly to wireless-next?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches