Re: [PATCH net-next v4 1/3] dt-bindings: net: Add T-HEAD dwmac support

From: Krzysztof Kozlowski
Date: Mon Oct 21 2024 - 03:37:35 EST


On Sun, Oct 20, 2024 at 07:36:00PM -0700, Drew Fustini wrote:
> From: Jisheng Zhang <jszhang@xxxxxxxxxx>
>
> Add documentation to describe the DesginWare-based GMAC controllers in
> the T-HEAD TH1520 SoC.
>
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx>
> [drew: rename compatible, add apb registers as second reg of gmac node,
> add clocks and interrupts poroperties]
> Signed-off-by: Drew Fustini <dfustini@xxxxxxxxxxxxxxx>

...

> + interrupts:
> + items:
> + - description: Combined signal for various interrupt events
> +
> + interrupt-names:
> + items:
> + - const: macirq
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
> + - interrupt-names

I asked to drop these, because referenced schema already requires these.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof