Re: [PATCH] wifi: ath12k: Fix for out-of bound access error

From: Kalle Valo
Date: Mon Oct 21 2024 - 05:08:03 EST


Karol Przybylski <karprzy7@xxxxxxxxx> writes:

> Size of array passed to print_array_to_buf_index is decremented by 1
>
> Discovered in coverity scan, CID 1600742
>
> Signed-off-by: Karol Przybylski <karprzy7@xxxxxxxxx>
> ---
> drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> index b2be7dade79f..74767ba9ec2b 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> +++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> @@ -1550,7 +1550,7 @@ ath12k_htt_print_tx_selfgen_ax_stats_tlv(const void *tag_buf, u16 tag_len,
> le32_to_cpu(htt_stats_buf->ax_mu_mimo_ndp));
> len += print_array_to_buf_index(buf, len, "ax_mu_mimo_brpollX_tried = ", 1,
> htt_stats_buf->ax_mu_mimo_brpoll,
> - ATH12K_HTT_TX_NUM_AX_MUMIMO_USER_STATS, "\n");
> + ATH12K_HTT_TX_NUM_AX_MUMIMO_USER_STATS-1, "\n");

A space before and after '-', please.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches