Re: [PATCH net-next v2 07/18] net: Register system page pool as an XDP memory model

From: Alexander Lobakin
Date: Mon Oct 21 2024 - 10:05:17 EST


From: Maciej Fijalkowski <maciej.fijalkowski@xxxxxxxxx>
Date: Thu, 17 Oct 2024 13:32:03 +0200

> On Tue, Oct 15, 2024 at 04:53:39PM +0200, Alexander Lobakin wrote:
>> From: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
>>
>> To make the system page pool usable as a source for allocating XDP
>> frames, we need to register it with xdp_reg_mem_model(), so that page
>> return works correctly. This is done in preparation for using the system
>> page pool for the XDP live frame mode in BPF_TEST_RUN; for the same
>> reason, make the per-cpu variable non-static so we can access it from
>> the test_run code as well.
>
> Again, to me BPF_TEST_RUN has nothing to do with libeth/idpf XDP support
> :<

Sorry, I forgot to adjust the commit message =\

Registering system page_pools as memory models is needed to introduce
generic XSk buff -> skb conversion (patch 15).

>
>>
>> Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>

Thanks,
Olek