Re: [PATCH net-next 05/15] net: sparx5: add registers required by lan969x

[Maxime Chevallier]

Hello Daniel,

On Mon, 21 Oct 2024 15:58:42 +0200
Daniel Machon <daniel.machon@xxxxxxxxxxxxx> wrote:

> Lan969x will require a few additional registers for certain operations.
> Some are shared, some are not. Add these.
> 
> Reviewed-by: Steen Hegelund <Steen.Hegelund@xxxxxxxxxxxxx>
> Signed-off-by: Daniel Machon <daniel.machon@xxxxxxxxxxxxx>

[...]

> +#define PTP_PTP_TWOSTEP_STAMP_SUBNS_STAMP_SUB_NSEC GENMASK(7, 0)

I understand that this is partly autogenerated, however the naming for
this register in particular seems very redundant... Is there any way
this could be improved ?

Thanks,

Maxime