Re: [PATCH v3 2/8] x86/sev: Add support for the RMPREAD instruction

From: Borislav Petkov
Date: Mon Oct 21 2024 - 13:49:41 EST


On Mon, Oct 21, 2024 at 12:10:55PM -0500, Tom Lendacky wrote:
> The input value is a 64-bit value and on output the return code is in
> EAX, a 32-bit value. So the use of the "=a" (ret) for output and "a"
> (pfn << PAGE_SHIFT) for input is more accurate.

Oh, they differ in width. Ok.

> It's not a complicated statement and is much clearer to me.
>
> I can change it if you really want the "+a" thing (including changing
> the ret variable to a u64), but would prefer not to do that.

Nah, it'll get uglier if you do. Let's keep it this way.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette