Re: [PATCH] clk: qcom: clk-alpha-pll: fix alpha mode configuration

[Gabor Juhos]

2024. 10. 21. 20:14 keltezéssel, Stephen Boyd írta:
> Quoting Gabor Juhos (2024-10-21 10:32:48)
>> Commit c45ae598fc16 ("clk: qcom: support for alpha mode configuration")
>> added support for configuring alpha mode, but it seems that the feature
>> was never working in practice.
>>
> [...]
>>
>> Applying the 'alpha_en_mask' fixes the initial rate of the PLLs showed
>> in the table above. Since the 'alpha_mode_mask' is not used by any driver
>> currently, that part of the change causes no functional changes.
>>
>> Cc: stable@xxxxxxxxxxxxxxx
>> Fixes: c45ae598fc16 ("clk: qcom: support for alpha mode configuration")
>> Signed-off-by: Gabor Juhos <j4g8y7@xxxxxxxxx>
>> ---
>> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
>> index f9105443d7dbb104e3cb091e59f43df25999f8b3..03cc7aa092480bfdd9eaa986d44f0545944b3b89 100644
>> --- a/drivers/clk/qcom/clk-alpha-pll.c
>> +++ b/drivers/clk/qcom/clk-alpha-pll.c
>> @@ -421,6 +421,8 @@ void clk_alpha_pll_configure(struct clk_alpha_pll *pll, struct regmap *regmap,
>>         mask |= config->pre_div_mask;
>>         mask |= config->post_div_mask;
>>         mask |= config->vco_mask;
>> +       mask |= config->alpha_en_mask;
>> +       mask |= config->alpha_mode_mask;
>>  
> 
> This is https://lore.kernel.org/all/20241019-qcs615-mm-clockcontroller-v1-1-4cfb96d779ae@xxxxxxxxxxx/

Oops, indeed. Sorry, I should have noticed that.

-Gabor