Re: [PATCH net-next] net: bnxt: use ethtool string helpers

From: Michael Chan
Date: Mon Oct 21 2024 - 18:19:41 EST


On Mon, Oct 21, 2024 at 2:05 PM Rosen Penev <rosenp@xxxxxxxxx> wrote:
> The only real way to satisfy everything is to use a temporary variable like
>
> for (i = 0; i < BNXT_NUM_PORT_STATS; i++) {
> const char *str = bnxt_port_stats_arr[i].string;
>
> ethtool_puts(&buf, str);
> }
>
> to make everything small.

This looks fine too. The actual function call looks clean on one line.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature