Re: [PATCH v2 06/10] x86/mce: Convert multiple if () statements into a switch() statement
From: Sohil Mehta
Date: Mon Oct 21 2024 - 20:07:27 EST
On 10/21/2024 4:31 PM, Luck, Tony wrote:
> Diamond Rapids is in Family 19, not 0x19. I was unsure in <asm/intel-family.h>
> to use decimal or hex for family (since only 5 & 6 are used there, and they are
> same in both bases). I picked decimal to avoid 0x prefixes everywhere.
>
Got it. In intel-family.h it probably doesn't matter. But across x86 the
family checks seem to be a mix of decimal and hexadecimal with maybe
more inclination towards hex.
> It appears that constant TSC started out model specific, but later
> got a proper enumeration bit in CPUID.
>
Ah! Makes sense.
> -Tony
>
>