Re: [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare()

From: Roman Gushchin
Date: Mon Oct 21 2024 - 22:15:02 EST


On Mon, Oct 21, 2024 at 09:34:24PM +0100, Matthew Wilcox wrote:
> On Mon, Oct 21, 2024 at 05:34:55PM +0000, Roman Gushchin wrote:
> > Fix it by moving the mlocked flag clearance down to
> > free_page_prepare().
>
> Urgh, I don't like this new reference to folio in free_pages_prepare().
> It feels like a layering violation. I'll think about where else we
> could put this.

I agree, but it feels like it needs quite some work to do it in a nicer way,
no way it can be backported to older kernels. As for this fix, I don't
have better ideas...