Re: [PATCH] dt-bindings: pinctrl: convert pinctrl-mcp23s08.txt to yaml format

From: Rob Herring (Arm)
Date: Tue Oct 22 2024 - 03:25:15 EST



On Tue, 22 Oct 2024 11:31:27 +0530, Himanshu Bhavani wrote:
> Convert the text bindings of pinctrl-mcp23s08 to YAML so it could be used to
> validate the DTS.
>
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@xxxxxxxxxxxxxxxxx>
> ---
> .../bindings/pinctrl/pinctrl-mcp23s08.txt | 148 -----------------
> .../bindings/pinctrl/pinctrl-mcp23s08.yaml | 153 ++++++++++++++++++
> 2 files changed, 153 insertions(+), 148 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.yaml
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.example.dts:85.3-86.1 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:129: Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2
make: *** [Makefile:224: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241022060157.36372-1-himanshu.bhavani@xxxxxxxxxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.