Re: [PATCH v1 1/3] drm/ci: refactor software-driver stage jobs

[Vignesh Raman]

Hi Daniel,

On 07/10/24 22:07, Daniel Stone wrote:
> Hi Vignesh,
>
> On Fri, 4 Oct 2024 at 09:31, Vignesh Raman <vignesh.raman@xxxxxxxxxxxxx> wrote:
> > +.software-driver:
> > +  stage: software-driver
> > +  extends:
> > +    - .test-gl
> > +    - .test-rules
> > +  timeout: "1h30m"
> > +  tags:
> > +    - kvm
> > +  script:
> > +    - ln -sf $CI_PROJECT_DIR/install /install
> > +    - mv install/bzImage /lava-files/bzImage
> > +    - mkdir -p /lib/modules
> > +    - mkdir -p $CI_PROJECT_DIR/results
> > +    - ln -sf $CI_PROJECT_DIR/results /results
> > +    - install/crosvm-runner.sh install/igt_runner.sh
>
> Instead of inlining this here, can we please move towards reusing more
> of .gitlab-ci/common/init-stage[12].sh? If those files need to be
> modified then that's totally fine, but I'd rather have something more
> predictable, and fewer random pieces of shell in each job section.

Sure. I will look into init-stage[12].sh and see if we can reuse it. Thanks.

Regards,
Vignesh