Re: [PATCH v6 3/7] mfd: Add new driver for MAX77705 PMIC

From: Dzmitry Sankouski
Date: Tue Oct 22 2024 - 04:38:00 EST


> > + /* Unmask interrupts from all blocks in interrupt source register */
> > + ret = regmap_update_bits(max77705->regmap,
> > + MAX77705_PMIC_REG_INTSRC_MASK,
> > + MAX77705_SRC_IRQ_ALL, (unsigned int)~MAX77705_SRC_IRQ_ALL);
>
> Why the cast?
>

BIT macro creates a 64 bit constant value. When inverted,
it overruns 32 bit value, causing compiler to warn on conversion like
`warning: conversion from ‘long unsigned int’ to ‘unsigned int’`.

--

Best regards,
Dzmitry