Re: [PATCH 1/2] dt-bindings: clock: mediatek: Add bindings for MT6735 syscon clock and reset controllers

From: AngeloGioacchino Del Regno
Date: Tue Oct 22 2024 - 05:05:13 EST


Il 21/10/24 14:16, Yassine Oudjana ha scritto:
From: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>

Add device tree bindings for syscon clock and reset controllers (IMGSYS,
MFGCFG, VDECSYS and VENCSYS).

Signed-off-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
---
.../bindings/clock/mediatek,syscon.yaml | 4 ++++
MAINTAINERS | 6 ++++++
.../dt-bindings/clock/mediatek,mt6735-imgsys.h | 15 +++++++++++++++
.../dt-bindings/clock/mediatek,mt6735-mfgcfg.h | 8 ++++++++
.../dt-bindings/clock/mediatek,mt6735-vdecsys.h | 9 +++++++++
.../dt-bindings/clock/mediatek,mt6735-vencsys.h | 11 +++++++++++
.../dt-bindings/reset/mediatek,mt6735-mfgcfg.h | 9 +++++++++
.../dt-bindings/reset/mediatek,mt6735-vdecsys.h | 10 ++++++++++
8 files changed, 72 insertions(+)
create mode 100644 include/dt-bindings/clock/mediatek,mt6735-imgsys.h
create mode 100644 include/dt-bindings/clock/mediatek,mt6735-mfgcfg.h
create mode 100644 include/dt-bindings/clock/mediatek,mt6735-vdecsys.h
create mode 100644 include/dt-bindings/clock/mediatek,mt6735-vencsys.h
create mode 100644 include/dt-bindings/reset/mediatek,mt6735-mfgcfg.h
create mode 100644 include/dt-bindings/reset/mediatek,mt6735-vdecsys.h


..snip..

diff --git a/include/dt-bindings/reset/mediatek,mt6735-vdecsys.h b/include/dt-bindings/reset/mediatek,mt6735-vdecsys.h
new file mode 100644
index 0000000000000..90ad73af50a3f
--- /dev/null
+++ b/include/dt-bindings/reset/mediatek,mt6735-vdecsys.h
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+
+#ifndef _DT_BINDINGS_RESET_MT6735_VDECSYS_H
+#define _DT_BINDINGS_RESET_MT6735_VDECSYS_H
+
+#define MT6735_VDEC_RST0_VDEC 0
+

Since you anyway have to send a new version, please remove this extra and
unneeded blank line for v2.

Anyway...

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>