Re: [PATCH] bpf: Fix out-of-bounds write in trie_get_next_key()

[Toke Høiland-Jørgensen]

Byeonguk Jeong <jungbu2855@xxxxxxxxx> writes:

> trie_get_next_key() allocates a node stack with size trie->max_prefixlen,
> while it writes (trie->max_prefixlen + 1) nodes to the stack when it has
> full paths from the root to leaves. For example, consider a trie with
> max_prefixlen is 8, and the nodes with key 0x00/0, 0x00/1, 0x00/2, ...
> 0x00/8 inserted. Subsequent calls to trie_get_next_key with _key with
> .prefixlen = 8 make 9 nodes be written on the node stack with size 8.
>
> Fixes: b471f2f1de8b ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map")
> Signed-off-by: Byeonguk Jeong <jungbu2855@xxxxxxxxx>

Makes sense!

Reviewed-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>