Re: [PATCH v2] posix-clock: posix-clock: Fix unbalanced locking in pc_clock_settime()

[Anna-Maria Behnsen]

Jinjie Ruan <ruanjinjie@xxxxxxxxxx> writes:

> If get_clock_desc() succeeds, it calls fget() for the clockid's fd,
> and get the clk->rwsem read lock, so the error path should release
> the lock to make the lock balance and fput the clockid's fd to make
> the refcount balance and release the fd related reosurce.

There is a typo: reosurce

>
> However the below commit left the error path locked behind resulting in
> unbalanced locking. Check timespec64_valid_strict() before
> get_clock_desc() to fix it, because the "ts" is not changed
> after that.
>
> Fixes: d8794ac20a29 ("posix-clock: Fix missing timespec64 check in pc_clock_settime()")
> Acked-by: Richard Cochran <richardcochran@xxxxxxxxx>
> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>

Acked-by: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx>