Re: [PATCH v9 24/37] common: Enable BLOBLIST_TABLES on arm

From: Simon Glass
Date: Tue Oct 22 2024 - 08:16:19 EST


Hi Peter,

On Mon, 21 Oct 2024 at 19:57, Peter Robinson <pbrobinson@xxxxxxxxx> wrote:
>
> > > > > Allow to use BLOBLIST_TABLES on arm to store ACPI or other tables.
> > > > >
> > > > > Signed-off-by: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx>
> > > > > Cc: Tom Rini <trini@xxxxxxxxxxxx>
> > > > > ---
> > > > > Changelog v9:
> > > > > - default to BLOBLIST_ALLOC on arm
> > > > > - Move default for BLOBLIST_SIZE_RELOC up
> > > > > ---
> > > > > common/Kconfig | 2 ++
> > > > > lib/Kconfig | 15 +++++++++------
> > > > > 2 files changed, 11 insertions(+), 6 deletions(-)
> > > > >
> > > >
> > > > This is fine, but please disable it for snow since it needs the FIXED
> > > > option for now.
> > >
> > > I cannot follow. What needs the FIXED option and what to disable?
> > > I run this patch on the CI and test_py_sandbox tests are still working.
> >
> > I mean that snow cannot use BLOBLIST_ALLOC and needs BLOBLIST_FIXED so
> > if you make ALLOC the default you need to change the default for snow.
>
> Simon by snow do you mean the device (configs/snow_defconfig) snow, I
> think Patrick doesn't know you're referring to what I believe to be a
> device config.

Oh OK, yes that is what I mean. If it is too confusing I can send a
fix-up patch after this series is applied.

Regards,
SImon