Re: [PATCH] selftests/sched: add basic test for psi

[Johannes Weiner]

On Tue, Oct 22, 2024 at 05:51:58PM +0530, Pintu Kumar wrote:
> There is a psi module that exists under kernel/sched/psi.
> Add a basic test to test the psi.

I'm not sure this is a valuable use of test cycles. The mere existence
and basic format of the files is very unlikely to be buggy, and such a
bug wouldn't hide for very long either.

> @@ -18548,10 +18548,12 @@ F:	include/uapi/linux/pps.h
>  PRESSURE STALL INFORMATION (PSI)
>  M:	Johannes Weiner <hannes@xxxxxxxxxxx>
>  M:	Suren Baghdasaryan <surenb@xxxxxxxxxx>
> +M:	Pintu Kumar <quic_pintu@xxxxxxxxxxx>

$ git log --oneline --author='Pintu Kumar' kernel/sched/psi.c | wc -l
0

Really? ;)

>  R:	Peter Ziljstra <peterz@xxxxxxxxxxxxx>
>  S:	Maintained
>  F:	include/linux/psi*
>  F:	kernel/sched/psi.c
> +F:	tools/testing/selftests/sched/psi_test.c
>  
>  PRINTK
>  M:	Petr Mladek <pmladek@xxxxxxxx>