Re: [PATCH v6 7/7] leds: max77705: Add LEDs support

[Dzmitry Sankouski]

(...)
> >  drivers/leds/leds-max77705.c | 157 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> Lol!  How big is your terminal? :)
>

Dunno actually, this was generated by b4

(...)


> No C++ comments please.
>

This conflicts with https://patchwork.kernel.org/comment/25898728/

> > +             ret = regmap_update_bits(led->regmap,
> > +                                     MAX77705_RGBLED_REG_LEDEN,
> > +                                     MAX77705_LED_EN_MASK << led->en_shift, 0);
> > +             max77705_rgb_blink(cdev, &blink_default, &blink_default);
> > +     } else {
> > +             // Set current
> > +             ret = regmap_write(led->regmap,
> > +                                led->reg_brightness, brightness);
>
> Line wrap at 100-chars.
>

>From coding-style.rst:
`The preferred limit on the length of a single line is 80 columns.`
I only exceed 80 chars, when there's no good wrapping.


-- 

Best regards,
Dzmitry