Re: [PATCH v4 3/6] iio: adc: adi-axi-adc: add interface type
From: David Lechner
Date: Tue Oct 22 2024 - 17:22:27 EST
On 10/18/24 5:42 AM, Antoniu Miclaus wrote:
> Add support for getting the interface (CMOS or LVDS) used by the AXI ADC
> IP.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> ---
...
> +static int axi_adc_interface_type_get(struct iio_backend *back,
> + enum iio_backend_interface_type *type)
> +{
> + struct adi_axi_adc_state *st = iio_backend_get_priv(back);
> + unsigned int val;
> + int ret;
> +
> + ret = regmap_read(st->regmap, ADI_AXI_ADC_REG_CONFIG, &val);
> + if (ret)
> + return ret;
> +
> + if (val & ADI_AXI_ADC_REG_CONFIG_CMOS_OR_LVDS_N)
> + *type = IIO_BACKEND_INTERFACE_CMOS;
> + else
> + *type = IIO_BACKEND_INTERFACE_LVDS;
These should be the more specific IIO_BACKEND_INTERFACE_SERIAL_CMOS
and IIO_BACKEND_INTERFACE_SERIAL_LVDS.
> +
> + return 0;
> +}
> +
> static struct iio_buffer *axi_adc_request_buffer(struct iio_backend *back,
> struct iio_dev *indio_dev)
> {
> @@ -285,6 +307,7 @@ static const struct iio_backend_ops adi_axi_adc_generic = {
> .iodelay_set = axi_adc_iodelays_set,
> .test_pattern_set = axi_adc_test_pattern_set,
> .chan_status = axi_adc_chan_status,
> + .interface_type_get = axi_adc_interface_type_get,
> };
>
> static int adi_axi_adc_probe(struct platform_device *pdev)