Re: [PATCH v2 0/2] mm/damon/vaddr: Fix issue in damon_va_evenly_split_region()

From: Zheng Yejian
Date: Tue Oct 22 2024 - 21:28:07 EST


On 2024/10/23 02:05, SeongJae Park wrote:
Hi Zheng,

On Tue, 22 Oct 2024 16:39:25 +0800 Zheng Yejian <zhengyejian@xxxxxxxxxxxxxxx> wrote:

[...]
To fix it, count for each piece split and make sure no more than
'nr_pieces'. In addition, add above case into damon_test_split_evenly().

And add 'nr_piece == 1' check in damon_va_evenly_split_region()
for better code readability and add a corresponding kunit testcase.

Zheng Yejian (2):
mm/damon/vaddr: Fix issue in damon_va_evenly_split_region()
mm/damon/vaddr: Check 'nr_piece == 1' case in
damon_va_evenly_split_region()

mm/damon/tests/vaddr-kunit.h | 2 ++
mm/damon/vaddr.c | 7 +++++--
2 files changed, 7 insertions(+), 2 deletions(-)

Thank you for addressing my comments and posting this new patch series. I
added my Reviewed-by: tags with some trivial comments to the patches.


Thanks for your review and comments !

Btw, at least on DAMON mailing list, we usually post new revisions as new
threads, rather than as a reply to the previous revision. If you want to make
sure involved people aware of the new series, you can send the lore link for
the new series as a reply to the previous revision.


Got it :)


Thanks,
SJ

--
Thanks,
Zheng Yejian