Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: Add sm8750 pinctrl

From: Bjorn Andersson
Date: Tue Oct 22 2024 - 23:22:23 EST


On Mon, Oct 21, 2024 at 04:04:13PM GMT, Melody Olvera wrote:
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8750-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8750-tlmm.yaml
[..]
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + tlmm: pinctrl@f100000 {
> + compatible = "qcom,sm8750-tlmm";
> + reg = <0x0f100000 0x300000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&tlmm 0 0 211>;

I know it's just an example, but I think this number should be 216.
Please also correct it in the dtsi, where you made it 220.

Regards,
Bjorn

> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> +
> + gpio-wo-state {
> + pins = "gpio1";
> + function = "gpio";
> + };
> +
> + uart-w-state {
> + rx-pins {
> + pins = "gpio60";
> + function = "qup1_se7";
> + bias-pull-up;
> + };
> +
> + tx-pins {
> + pins = "gpio61";
> + function = "qup1_se7";
> + bias-disable;
> + };
> + };
> + };
> +...
> --
> 2.46.1
>