Re: [PATCH v2] kfifo: don't include dma-mapping.h in kfifo.h
From: Greg KH
Date: Wed Oct 23 2024 - 02:01:12 EST
On Wed, Oct 23, 2024 at 07:53:04AM +0200, Christoph Hellwig wrote:
> Nothing in kfifo.h directly needs dma-mapping.h, only two macros
> use DMA_MAPPING_ERROR when actually instantiated. Drop the
> dma-mapping.h include to reduce include bloat.
>
> Add an explicity <linux/io.h> include to drivers/mailbox/omap-mailbox.c
> as that file uses __raw_readl and __raw_writel through a complicated
> include chain involving <linux/dma-mapping.h>
>
> Fixes: d52b761e4b1a ("kfifo: add kfifo_dma_out_prepare_mapped()")
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>
> Changes since v1:
> - improve the commit log
As the original commit came in through the tty tree, I'll take this through
the same tree as well.
thanks,
greg k-h