Re: [PATCH v4 1/6] Add AutoFDO support for Clang build

[Masahiro Yamada]

On Tue, Oct 22, 2024 at 7:43 AM Rong Xu <xur@xxxxxxxxxx> wrote:
>
> Thanks for the detailed suggestions! My comments are inlined below.
>
> Best regards,
>
> -Rong
>
> On Sun, Oct 20, 2024 at 9:33 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> >
> > On Tue, Oct 15, 2024 at 6:33 AM Rong Xu <xur@xxxxxxxxxx> wrote:
> >
> >
> > > +Customization
> > > +=============
> > > +
> > > +You can enable or disable AutoFDO build for individual file and directories by
> > > +adding a line similar to the following to the respective kernel Makefile:
> >
> >
> > Perhaps, it might be worth mentioning that kernel space objects are
> > covered by default.
> >
> > Then, people would understand ':= y' will be less common than ':= n'.
> >
>
> Good point! How about I change to the following:
> "
> The default CONFIG_AUTOFDO_CLANG setting covers kernel space objects for
> AutoFDO builds. One can, however, enable or disable AutoFDO build for
> individual file and directories by adding a line similar to the following
> to the respective kernel Makefile ...


Sounds ok to me.





--
Best Regards
Masahiro Yamada